Fixup dead links #24167
Merged
Fixup dead links #24167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
commented
Mar 16, 2023
Comment on lines
-23
to
+27
| * If writing a source in Python, check out this [readme](../base-python-test/readme.md) | ||
|
|
||
| - If writing a source in Python, **don't use this.** |
There was a problem hiding this comment.
Wait... why have this line? is there a place we can link them too?
Comment on lines
-130
to
+139
| A log grouping tool is under construction: https://www.youtube.com/watch&ab_channel=Dagger | ||
| A log grouping tool is under construction |
There was a problem hiding this comment.
@alafanechere I don't know what you meant to link, but I don't think it matters to much here 🤷
bnchrch
reviewed
Mar 16, 2023
Comment on lines
-23
to
+27
| * If writing a source in Python, check out this [readme](../base-python-test/readme.md) | ||
|
|
||
| - If writing a source in Python, **don't use this.** |
There was a problem hiding this comment.
Wait... why have this line? is there a place we can link them too?
sophia-wiley
approved these changes
Mar 16, 2023
|
Oops... automerged!
So this package is a special collection of /unit tests/ that only the java database sources use. python connector do their own thing now. Everyone uses CAT, and that's a different package. |
|
ah ok that makes sense! |
adriennevermorel
pushed a commit
to adriennevermorel/airbyte
that referenced
this pull request
Mar 17, 2023
erohmensing
pushed a commit
that referenced
this pull request
Mar 22, 2023
erohmensing
pushed a commit
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup dead links that @sophia-wiley found